Implement handling of new cookie received from SU platform by MattyTheHacker · Pull Request #722 · CSSUoB/TeX-Bot-Py-V2

MattyTheHacker · 2026-02-20T00:40:29Z

Note this will need the cookie checking task (or some other query) to run more often than the cookie expires. For MSL this appears to be about 15 minutes

Copilot

Pull request overview

This pull request implements automatic handling of cookie updates from the SU platform. The MSL platform returns updated authentication cookies in HTTP responses that expire approximately every 15 minutes. The PR refactors cookie management to detect and store these updated cookies, and consolidates duplicate HTTP session handling code.

Changes:

Introduced fetch_url_content_with_session function to handle HTTP requests with automatic cookie update detection and storage
Refactored fetch_community_group_members_list to use the new shared session handling function
Removed duplicate HTTP session code from CheckSUPlatformAuthorisationBaseCog class

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
utils/msl/memberships.py	Added `fetch_url_content_with_session` function to detect and update cookies from server responses; refactored `fetch_community_group_members_list` to use new function
utils/msl/init.py	Exported new `fetch_url_content_with_session` function
cogs/check_su_platform_authorisation.py	Removed duplicate HTTP session handling code; replaced with calls to shared `fetch_url_content_with_session` function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utils/msl/memberships.py

Copilot · 2026-02-20T00:43:53Z

utils/msl/memberships.py


-BASE_SU_PLATFORM_WEB_COOKIES: "Final[Mapping[str, str]]" = {
-    ".AspNet.SharedCookie": settings["SU_PLATFORM_ACCESS_COOKIE"],
+BASE_SU_PLATFORM_WEB_COOKIES: "Final[MutableMapping[str, str]]" = {


The type annotation Final[MutableMapping[str, str]] is contradictory. Final indicates the variable binding cannot be reassigned, but MutableMapping indicates the contents are mutable. While Python will allow this at runtime, it violates the semantic intent of Final and may confuse type checkers. Consider either:

Using MutableMapping[str, str] without Final (recommended, since the dictionary contents are mutated)

Using a different pattern that doesn't mix immutability guarantees with mutable collections

Suggested change

BASE_SU_PLATFORM_WEB_COOKIES: "Final[MutableMapping[str, str]]" = {

BASE_SU_PLATFORM_WEB_COOKIES: "MutableMapping[str, str]" = {

I neither know nor care if this matters, the code runs fine - Matt up to you if you want this fixed

I think the correct annotation here is Mapping[str, str]. Then when you need to update the cookie, assign a new dict to BASE_SU_PLATFORM_WEB_COOKIES rather than just updating the key.

CarrotManMatt · 2026-02-20T01:28:32Z

utils/msl/memberships.py


-BASE_SU_PLATFORM_WEB_COOKIES: "Final[Mapping[str, str]]" = {
-    ".AspNet.SharedCookie": settings["SU_PLATFORM_ACCESS_COOKIE"],
+BASE_SU_PLATFORM_WEB_COOKIES: "Final[MutableMapping[str, str]]" = {


I think the correct annotation here is Mapping[str, str]. Then when you need to update the cookie, assign a new dict to BASE_SU_PLATFORM_WEB_COOKIES rather than just updating the key.

CarrotManMatt · 2026-02-20T01:28:59Z

utils/msl/memberships.py


 logger: "Final[Logger]" = logging.getLogger("TeX-Bot")

+SU_PLATFORM_ACCESS_COOKIE: "Final[str]" = settings["SU_PLATFORM_ACCESS_COOKIE"]


settings["SU_PLATFORM_ACCESS_COOKIE"] can be used directly, rather than assigning to a variable first.

CarrotManMatt · 2026-02-20T01:31:33Z

utils/msl/memberships.py

+        http_session.get(url=url, ssl=GLOBAL_SSL_CONTEXT) as http_response,
    ):
-        response_html: str = await http_response.text()
+        returned_asp_cookie: Morsel | None = http_response.cookies.get(".AspNet.SharedCookie")  # type: ignore[type-arg]


What is the need to use # type: ignore[type-arg] here?

CarrotManMatt · 2026-02-20T01:31:51Z

utils/msl/memberships.py

-        response_html: str = await http_response.text()
+        returned_asp_cookie: Morsel | None = http_response.cookies.get(".AspNet.SharedCookie")  # type: ignore[type-arg]
+        if (
+            returned_asp_cookie


Suggested change

returned_asp_cookie

returned_asp_cookie is not None

CarrotManMatt · 2026-02-20T01:32:09Z

utils/msl/memberships.py

+            and returned_asp_cookie.value
+            != BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"]


Suggested change

and returned_asp_cookie.value

!= BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"]

and (

returned_asp_cookie.value

!= BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"]

)

CarrotManMatt · 2026-02-20T01:32:41Z

utils/msl/memberships.py

+            != BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"]
+        ):
+            logger.info("SU platform access cookie was updated by the server; updating local.")
+            BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"] = returned_asp_cookie.value


Suggested change

BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"] = returned_asp_cookie.value

BASE_SU_PLATFORM_WEB_COOKIES = {".AspNet.SharedCookie": returned_asp_cookie.value}

codecov · 2026-02-20T01:57:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

MattyTheHacker added 3 commits February 17, 2026 15:47

Refactor fetch method to one location

eed5eda

minor improvement

2d80f50

Improve new cookie handling

b47e85d

MattyTheHacker self-assigned this Feb 20, 2026

Copilot AI review requested due to automatic review settings February 20, 2026 00:40

MattyTheHacker requested a review from CarrotManMatt as a code owner February 20, 2026 00:40

MattyTheHacker added the enhancement New feature or request label Feb 20, 2026

Copilot started reviewing on behalf of MattyTheHacker February 20, 2026 00:40 View session

MattyTheHacker deployed to publish February 20, 2026 00:43 — with GitHub Actions Active

Copilot AI reviewed Feb 20, 2026

View reviewed changes

MattyTheHacker enabled auto-merge (squash) February 20, 2026 00:50

CarrotManMatt requested changes Feb 20, 2026

View reviewed changes

	BASE_SU_PLATFORM_WEB_COOKIES: "Final[MutableMapping[str, str]]" = {
	BASE_SU_PLATFORM_WEB_COOKIES: "MutableMapping[str, str]" = {


		logger: "Final[Logger]" = logging.getLogger("TeX-Bot")

		SU_PLATFORM_ACCESS_COOKIE: "Final[str]" = settings["SU_PLATFORM_ACCESS_COOKIE"]

		and returned_asp_cookie.value
		!= BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"]

	BASE_SU_PLATFORM_WEB_COOKIES[".AspNet.SharedCookie"] = returned_asp_cookie.value
	BASE_SU_PLATFORM_WEB_COOKIES = {".AspNet.SharedCookie": returned_asp_cookie.value}

Conversation

MattyTheHacker commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 20, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments